openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

ENT-1529 | learner report pricing column is not pulling price from time of enrollment #789

Closed HammadAhmadWaqas closed 4 years ago

HammadAhmadWaqas commented 4 years ago

Using the order_line table to extract prices of enrollments instead of partner_stockrecord to support changes, updated a test. also removed bad data from test input fixtures.

Analytics Pipeline Pull Request

Make sure that the following steps are done before merging:

codecov[bot] commented 4 years ago

Codecov Report

Merging #789 into master will increase coverage by 0.04%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #789      +/-   ##
==========================================
+ Coverage   74.54%   74.59%   +0.04%     
==========================================
  Files         211      211              
  Lines       24085    24152      +67     
==========================================
+ Hits        17953    18015      +62     
- Misses       6132     6137       +5
Impacted Files Coverage Δ
...alytics/tasks/enterprise/enterprise_enrollments.py 83.87% <ø> (ø) :arrow_up:
...ks/tests/acceptance/test_enterprise_enrollments.py 40% <ø> (ø) :arrow_up:
...dx/analytics/tasks/insights/location_per_course.py 85.38% <0%> (-1.07%) :arrow_down:
edx/analytics/tasks/programs/program_reports.py 93.84% <0%> (-0.05%) :arrow_down:
...ytics/tasks/programs/tests/test_program_reports.py 100% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ab45d6...c0a6259. Read the comment docs.