openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

ENT-1529 | learner report pricing column is not pulling price from time of enrollment #790

Closed HammadAhmadWaqas closed 4 years ago

HammadAhmadWaqas commented 4 years ago

Using the order_line table to extract prices of enrollments instead of partner_stockrecord to support changes, updated a test. Analytics Pipeline Pull Request

Make sure that the following steps are done before merging:

codecov[bot] commented 4 years ago

Codecov Report

Merging #790 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #790   +/-   ##
=======================================
  Coverage   74.59%   74.59%           
=======================================
  Files         211      211           
  Lines       24152    24152           
=======================================
  Hits        18015    18015           
  Misses       6137     6137
Impacted Files Coverage Δ
...ks/tests/acceptance/test_enterprise_enrollments.py 40% <ø> (ø) :arrow_up:
...alytics/tasks/enterprise/enterprise_enrollments.py 83.87% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5df2e3a...e3ac551. Read the comment docs.

brianhw commented 4 years ago

LGTM. 👍