search

openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

BOM-2951: Replace Travis with GitHub CI #872

Closed UsamaSadiq closed 2 years ago

UsamaSadiq commented 2 years ago

Issue: BOM-2951

Description

codecov[bot] commented 2 years ago

Codecov Report

Merging #872 (23a3bbf) into master (bed85a8) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #872   +/-   ##
=======================================
  Coverage   76.38%   76.38%           
=======================================
  Files         150      150           
  Lines       17128    17128           
=======================================
  Hits        13083    13083           
  Misses       4045     4045

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bed85a8...23a3bbf. Read the comment docs.

estute commented 2 years ago

@UsamaSadiq I'm not quite sure yet, but even though the make target test-docker passes the -t flag to docker-run, the Github Actions environment is still complaining about it not being a real TTY. After some digging, I found this example, which seems to do the trick: https://github.com/gfx/example-github-actions-with-tty/blob/4c5f457c65dfe61e273e0470414699420be5e134/.github/workflows/test.yml#L18. It's a temporary fix to get this merged in. I will follow up with other teams to see if there is a better way of dealing with this issue.