openedx-unsupported / edx-analytics-pipeline

GNU Affero General Public License v3.0
91 stars 116 forks source link

fix: fix event exclusion logic in event exports for aggregated tracki… #882

Closed HassanJaveed84 closed 1 year ago

HassanJaveed84 commented 2 years ago

…ng logs.

Analytics Pipeline Pull Request

Make sure that the following steps are done before merging:

codecov[bot] commented 2 years ago

Codecov Report

Base: 76.38% // Head: 76.30% // Decreases project coverage by -0.08% :warning:

Coverage data is based on head (02c440f) compared to base (b04b543). Patch coverage: 66.66% of modified lines in pull request are covered.

:exclamation: Current head 02c440f differs from pull request most recent head c6cf3d1. Consider uploading reports for the commit c6cf3d1 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #882 +/- ## ========================================== - Coverage 76.38% 76.30% -0.09% ========================================== Files 150 150 Lines 17128 17115 -13 ========================================== - Hits 13083 13059 -24 - Misses 4045 4056 +11 ``` | [Impacted Files](https://codecov.io/gh/openedx/edx-analytics-pipeline/pull/882?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...analytics/tasks/export/tests/test\_event\_exports.py](https://codecov.io/gh/openedx/edx-analytics-pipeline/pull/882/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-ZWR4L2FuYWx5dGljcy90YXNrcy9leHBvcnQvdGVzdHMvdGVzdF9ldmVudF9leHBvcnRzLnB5) | `99.45% <ø> (-0.04%)` | :arrow_down: | | [edx/analytics/tasks/export/event\_exports.py](https://codecov.io/gh/openedx/edx-analytics-pipeline/pull/882/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-ZWR4L2FuYWx5dGljcy90YXNrcy9leHBvcnQvZXZlbnRfZXhwb3J0cy5weQ==) | `83.44% <66.66%> (-1.38%)` | :arrow_down: | | [edx/analytics/tasks/common/pathutil.py](https://codecov.io/gh/openedx/edx-analytics-pipeline/pull/882/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-ZWR4L2FuYWx5dGljcy90YXNrcy9jb21tb24vcGF0aHV0aWwucHk=) | `75.79% <0.00%> (-5.74%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.