openedx-unsupported / edx-app-android

The Open edX mobile app for Android!
https://docs.google.com/document/d/15MYZ2LAmahB82P5wkPkQOqjszfou0Qkeae3qz7STxUQ/edit
Apache License 2.0
299 stars 333 forks source link

fix: Resolved Microsoft Login Issue #1812

Closed HamzaIsrar12 closed 1 year ago

HamzaIsrar12 commented 1 year ago

Description

LEARNER-9520

The issue arises when attempting to log out the learner during the login process. The problem is caused by the presence of multiple Microsoft client instances across various threads. To address this, we have successfully resolved the issue by transitioning to a callback-based approach for signing out the learner.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01% :warning:

Comparison is base (5b3043d) 1.13% compared to head (0c16e30) 1.13%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## rc/4.1.1 #1812 +/- ## ============================================= - Coverage 1.13% 1.13% -0.01% Complexity 137 137 ============================================= Files 534 534 Lines 25186 25191 +5 Branches 3039 3040 +1 ============================================= Hits 286 286 - Misses 24873 24878 +5 Partials 27 27 ``` | [Files Changed](https://app.codecov.io/gh/openedx/edx-app-android/pull/1812?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...a/org/edx/mobile/social/microsoft/MicrosoftAuth.kt](https://app.codecov.io/gh/openedx/edx-app-android/pull/1812?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-T3BlbkVkWE1vYmlsZS9zcmMvbWFpbi9qYXZhL29yZy9lZHgvbW9iaWxlL3NvY2lhbC9taWNyb3NvZnQvTWljcm9zb2Z0QXV0aC5rdA==) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.