openedx-unsupported / edx-app-android

The Open edX mobile app for Android!
https://docs.google.com/document/d/15MYZ2LAmahB82P5wkPkQOqjszfou0Qkeae3qz7STxUQ/edit
Apache License 2.0
299 stars 333 forks source link

fix: Discovery WebViews Issues #1828

Closed HamzaIsrar12 closed 1 year ago

HamzaIsrar12 commented 1 year ago

Description

LEARNER-9636 | LEARNER-9637

Creating PR on behalf of @farhan-arshad-dev

codecov[bot] commented 1 year ago

Codecov Report

Attention: 279 lines in your changes are missing coverage. Please review.

Comparison is base (6ef292f) 1.09% compared to head (ab50590) 1.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1828 +/- ## =========================================== - Coverage 1.09% 1.08% -0.01% Complexity 137 137 =========================================== Files 538 538 Lines 26044 26278 +234 Branches 3323 3377 +54 =========================================== Hits 284 284 - Misses 25733 25967 +234 Partials 27 27 ``` | [Files](https://app.codecov.io/gh/openedx/edx-app-android/pull/1828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx) | Coverage Δ | | |---|---|---| | [...obile/view/custom/URLInterceptorWebViewClient.java](https://app.codecov.io/gh/openedx/edx-app-android/pull/1828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-T3BlbkVkWE1vYmlsZS9zcmMvbWFpbi9qYXZhL29yZy9lZHgvbW9iaWxlL3ZpZXcvY3VzdG9tL1VSTEludGVyY2VwdG9yV2ViVmlld0NsaWVudC5qYXZh) | `0.00% <ø> (ø)` | | | [...a/org/edx/mobile/view/WebViewDiscoverFragment.java](https://app.codecov.io/gh/openedx/edx-app-android/pull/1828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-T3BlbkVkWE1vYmlsZS9zcmMvbWFpbi9qYXZhL29yZy9lZHgvbW9iaWxlL3ZpZXcvV2ViVmlld0Rpc2NvdmVyRnJhZ21lbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | | | [.../org/edx/mobile/view/custom/NestedScrollWebView.kt](https://app.codecov.io/gh/openedx/edx-app-android/pull/1828?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openedx#diff-T3BlbkVkWE1vYmlsZS9zcmMvbWFpbi9qYXZhL29yZy9lZHgvbW9iaWxlL3ZpZXcvY3VzdG9tL05lc3RlZFNjcm9sbFdlYlZpZXcua3Q=) | `0.00% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.