refactor: use links to navigate to library detail

openedx-unsupported / frontend-app-library-authoring

DEPRECATED. To be migrated into frontend-app-course-authoring.

GNU Affero General Public License v3.0

3 stars 25 forks source link

refactor: use links to navigate to library detail #437

Closed imasdekar closed 3 months ago

imasdekar commented 3 months ago

Makes the library card in the library list page, which navigate to a different page on click, to appear as links i.e. making the navigation address visible on hover.

closes #414

Signed-off by: Ishan Masdekar imasdekar@disroot.org

openedx-webhooks commented 3 months ago

Thanks for the pull request, @imasdekar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 53.07%. Comparing base (7303f79) to head (77ce1be). Report is 7 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #437 +/- ## ========================================== - Coverage 53.14% 53.07% -0.07% ========================================== Files 80 80 Lines 2021 2018 -3 Branches 368 362 -6 ========================================== - Hits 1074 1071 -3 Misses 914 914 Partials 33 33 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

itsjeyd commented 3 months ago

@imasdekar Thank you for this contribution!

It looks like the changes are fixing a known issue (#414), so I'm assuming that we won't need to send them through product review.

And we have a green build, so I'm marking this PR as ready for review.

CC @connorhaugh as reporter of #414

itsjeyd commented 3 months ago

@imasdekar @navinkarkera Marking this PR as ready for merge.

openedx-webhooks commented 3 months ago

@imasdekar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.