openedx-unsupported / tutor-contrib-clickhouse

0 stars 1 forks source link

fix: remove override command in k8s job #13

Closed mariajgrimaldi closed 1 year ago

mariajgrimaldi commented 1 year ago

Description

This PR removes the command override from the clickhouse job which prevented its execution. This override it's not needed since tutor adds something similar when rendering the job: image

So with the command override: empty-job

Without the override: job-running

How to test

Run: tutor k8s do init --limit clickhouse then get the job output.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @mariajgrimaldi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

itsjeyd commented 1 year ago

Hey @mariajgrimaldi, thank you for this contribution. Are the changes ready for review?

itsjeyd commented 1 year ago

label: core contributor

openedx-webhooks commented 1 year ago

@mariajgrimaldi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.