openedx / .github

Centralized openedx repository workflows, community health files, etc.
1 stars 24 forks source link

Replace `ccp-` teams with `committers-` teams #132

Open kdmccormick opened 4 months ago

kdmccormick commented 4 months ago

Context

We have two types of teams for giving Coding CCs write access to repos: ccp-$USERNAME teams and committers-$TOPIC teams. This wiki page explains the difference.

Why do we have both types in the first place?

Well, generally, we don't want to give CCs write access directly on any repos. It makes the program harder to audit, because we don't know what access is CC access on what access is special/legacy/accidental. So, we started with the ccp-$USERNAME teams because there was only a small number of CCs, and having a 1:1 user-team mapping was straightforward.

As the number of CCs grew, some of them gained write access to whole sets of repos (i.e., "all analytics" and "all MFEs"). It got harder to manage individual repos for individual users. It also got ambiguous whether, for instance, a CC with access to "all MFEs" should automatically gain access to new MFEs--to that question, we decided "yes", as long as their CC nomination thread made that clear.

So, we started grouping repos together with teams. The first teams like this were were frontend-all, frontend-mfes, and cc-analytics. Eventually, we decided to standardize on the committers-* name for all these sort of teams, so those teams are now committers-frontend, committers-frontend-apps, and committers-analytics, respectively. For CCs who have access to a single repo rather than a repo group, we figured that we could just have some one-off teams like committers-edx-platform.

We should finish switching from ccp-* teams to committers-* teams. The only reason we haven't is that it's one of those high-importance-but-low-urgency things.

Tasks

Go to the CC access wiki page. Also open up the list of committers- teams.

Look for logical groupings of repos that appear multiple times on the wiki page. Create these groupings as new committers- teams if they don't already exist.

Then, for every CC:

General notes:

sarina commented 2 months ago

@kdmccormick what wouldl you say the priority of this issue is?

kdmccormick commented 2 months ago

Low urgency, medium-high importance

sarina commented 2 months ago

Agreed. I wonder if there's a way (label? new column on board?) that we could add these to that are like, "if you're on-call and it's a light week, please take one of these tasks"