openedx / ConceptXBlock

edX: An XBlock for adding concept tags. There is an associated external service in a different repo.
GNU Affero General Public License v3.0
1 stars 3 forks source link

ConceptXBlock | Drop py3.8 support | replace pkg_resource with importlib.resources #161

Open OmerBhatti opened 2 weeks ago

OmerBhatti commented 2 weeks ago

Ticket: Move on from deprecated pkg_resources api #159

PR is expected to merge after merging this PR : chore: Upgrade Python requirements

Followed migration guide: https://importlib-resources.readthedocs.io/en/latest/migration.html

Testing: I have tested the changes with following steps:

Screenshots

image
openedx-webhooks commented 2 weeks ago

Thanks for the pull request, @OmerBhatti!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Submit a signed contributor agreement (CLA)

:warning: We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation. Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by adding a comment below that you have signed it. If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently unmaintained.

To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:

  1. On the right-hand side of the PR, find the Contributions project, click the caret in the top right corner to expand it, and check the "Primary PM" field for the name of your PM.
  2. Find their GitHub handle here.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

mphilbrick211 commented 1 week ago

Hi @OmerBhatti! As mentioned in other pull requests - please have your manager reach out to oscm@axim.org to have you added to edly's existing contributor agreement. Thanks!

farhan commented 1 week ago

@feanil @kdmccormick Can you guys please merge this as its blocking this PR.

farhan commented 1 week ago

@OmerBhatti Screen shot seems not rendered properly or is it the right behaviour, can you please check them before this PR