Closed shadinaif closed 1 year ago
Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Please review @OmarIthawi @brian-smith-tcril
@OmarIthawi , regarding requirements issue: yes some requirements are missing. But the command make extract_messages
is to be used by openedx-translations
only. Knowing that openedx-translations
handles those requirements in its process
this seems good to go - @brian-smith-tcril , are you planning to merge?
@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
fix:
django.po
contains duplicate entriesThis is considered a patch for https://github.com/openedx/RecommenderXBlock/pull/68 . Transefix failed to add translation extracted from this repo because of a duplicate msg in
django.po
References
This pull request is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.
Check the links above for full information about the overall project.
Internalization is being rearchitected in Open edX Python, XBlock, Micro-frontend, and other projects. There are a number of immediately visible changes:
.json
,.po
or.mo
files will be committed into the repos.make extract_translations
in all repositoriesBreaking Changes
One of the primary goals of the project is to avoid breaking changes. If you noticed any suspicious code, please raise your concern. But before that, please know the strategy we're following to avoid breaking changes
For XBlocks:
conf/locale
. Therefore, we are creating a link fromconf/locale
totranslations
so Atlas can find the path without disrupting the current way of having translations locally within the XBlocks