Closed ArturGaspar closed 10 months ago
Thanks for the pull request, @ArturGaspar! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Hi @ArturGaspar - is this all set for review?
@mphilbrick211 Yes.
Hi @openedx/2u-arbi-bom! This is ready for review.
@ArturGaspar Please bump the version.
@awais786 Done.
@ArturGaspar 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
Recommender XBlock will currently generate invalid URLs if used with S3 backend. This fixes that.
Using the filesystem backend should be unaffected as it ignores the timeout parameter (https://github.com/openedx/django-pyfs/blob/v3.4.1/djpyfs/djpyfs.py#L116).
Testing instructions
Other information
Private-ref: https://tasks.opencraft.com/browse/BB-8077