openedx / RecommenderXBlock

edX: An XBlock to recommend resources to other students, written by Daniel Li, under my supervision
GNU Affero General Public License v3.0
5 stars 16 forks source link

feat!: remove Transifex calls for FC-0012 - OEP-58 #77

Closed shadinaif closed 6 months ago

shadinaif commented 8 months ago

Breaking change!


This PR depends on https://github.com/openedx/RecommenderXBlock/pull/81 and contains a cherry-pick from it until that one is merged


This change breaks the Jenkins transifex integration which has been deprecated in favor of the new GitHub Transifex App integration as part of OEP-58.

Changes

Merge timeline

This should only be merged after Translation Infrastructure update OEP-58 is fully implemented.

The timing announcement will be shared by @brian-smith-tcril on #translations-project-fc-0012 Open edX Slack channel.

## Keep this pull request as a draft to prevent an accidental merge. ##

Pre-merge checklist

References

This contribution is part of the FC-0012 project which is sparked by the Translation Infrastructure update OEP-58.

Up-to-date project overview and details are available in the Approach Memo and Technical Discovery: Translations Infrastructure Implementation document.

Join the conversation on Open edX Slack #translations-project-fc-0012.

Check the links above for full information about the overall project.

openedx-webhooks commented 8 months ago

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

shadinaif commented 8 months ago

for your review please @OmarIthawi

OmarIthawi commented 6 months ago

Done @brian-smith-tcril!

openedx-webhooks commented 6 months ago

@shadinaif 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.