search

openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 5 forks source link

feat: adds fact_enrollments model (FC-0024) #18

Closed SoryRawyer closed 1 year ago

SoryRawyer commented 1 year ago

This PR adds a model, fact_enrollments, which enriches the enrollment_events MV with metadata provided by the course_names lookup table.

If merged, this will allow us to convert the fact_enrollments Superset dataset to a physical dataset. We can also simplify the fact_enrollments_by_day dataset by relying on this model instead of including another jinja template from the Superset assets directory. I've confirmed this model has the same columns as the Superset dataset it's replacing and has columns for all dashboard filters.

This PR also removes two unused enrollments models (they've since moved to the Superset assets directory in tutor-contrib-aspects).

bmtcril commented 1 year ago

Do any tests need to be updated for this?

SoryRawyer commented 1 year ago

Not that I can tell. Removing the old enrollment models from schema.yml also deletes the tests that were run on that model. Running dbt test locally works for me.