openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 4 forks source link

fix: correctly pass through entity names (FC-0024) #21

Closed SoryRawyer closed 1 year ago

SoryRawyer commented 1 year ago

Fixes issues with the problem interaction models where fields weren't being passed through correctly, leading to errors at query time.

This PR also updates the strategy for joining entity names, avoiding an unnecessary join in the fact_learner_problem_summary model. dbt test now succeeds and these models correctly display data in the instructor dashboard. This should unblock the corresponding PR in tutor-contrib-aspects.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 1 year ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bmtcril commented 1 year ago

Merged and released as v1.3.1