fix: properly expose index in problem responses (FC-0033)

openedx / aspects-dbt

The dbt project for Open edX Aspects!

Apache License 2.0

2 stars 4 forks source link

fix: properly expose index in problem responses (FC-0033) #26

Closed SoryRawyer closed 1 year ago

SoryRawyer commented 1 year ago

This change replaces the course_key field in fact_problem_responses with the field from problem_events instead of the field from course_names. This was preventing queries from properly using the course_key index on problem_events.

This also includes a fix for the fact_learner_problem_summary test, which was pointing to an earlier name of that model.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 1 year ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bmtcril commented 1 year ago

Released as v2.2.1