Closed SoryRawyer closed 1 year ago
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Released as v2.3
!
This creates a view,
dim_course_blocks
, that leverages ClickHouse's "direct" join type to improve query performance when adding entity names to larger datasets.This view could also be used for the
dim_course_videos
anddim_course_problems
datasets that Superset uses for dashboard filters.Please note: to get this working with Superset, I needed to grant
dictGet
permissions to theevent_sink
database for the Aspects reporting user. I can add that in a subsequent PR to use a version of this project that includes this change in the aspects tutor plugin.