openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 4 forks source link

feat: support multi-part problem responses (FC-0033) #33

Closed SoryRawyer closed 10 months ago

SoryRawyer commented 10 months ago

Responses to multi-part problems are currently excluded from fact_problem_responses because the regular expression for parsing problem IDs was incorrectly handling object IDs for distinct parts of problems. This PR changes the regular expression to accurately parse problem IDs while also removing duplicate problem response records (the first part in a multi-part question seems to have two records for every problem check event).

openedx-webhooks commented 10 months ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 10 months ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bmtcril commented 10 months ago

Released as v2.7