Closed SoryRawyer closed 8 months ago
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@bmtcril this is ready for review. The dbt version upgrades seem to work without issue and the MVs seem to match what I have with the alembic-created tables.
Sorry I was waiting for this to merge, can you pull in these new ones in as well? Then we should be able to make the changeover. https://github.com/openedx/tutor-contrib-aspects/pull/529
Just to be sure, are you talking about the user profile table? I don't see any views in that PR and I don't think dictionaries are supported by dbt-clickhouse.
Sorry, I just noticed that the user profile table is mentioned in this issue as being included in the alembic migrations. I think the only MV in our migrations that isn't listed in that issue is the most recent blocks MV. Do you want me to include that in this PR?
Hmmm yeah I think we should move everything we can that's not a "base needed to write to" table. If you could confirm about the dictionaries that would be great. Seems like another thing ripe for an upstream PR.
(FWIW I don't think the dictionaries thing is blocking this at all, just curious about it for future work)
Apologies for the delay - dictionaries aren't supported at the moment, but that does seem like something we could contribute to dbt-clickhouse.
@SoryRawyer can you handle Brian comment around the Json extract float, and squash the commits?
@bmtcril were you imagining the xapi_events_all_parsed
being part of this PR as well? I think that might be the last MV in the alembic migrations.
@SoryRawyer sure, let's move it 👍
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Now that dbt-clickhouse supports materialized views, this PR moves MV creation and maintenance to the Aspects dbt project. MV definitions are included for:
xapi_events_all_parsed
completion_events
enrollment_events
forum_events
grading_events
problem_events
video_playback_events