fix: handle empty string scaled_score values

openedx / aspects-dbt

The dbt project for Open edX Aspects!

Apache License 2.0

2 stars 5 forks source link

fix: handle empty string scaled_score values #36

Closed bmtcril closed 10 months ago

bmtcril commented 10 months ago

This is showing up on the beta server, so it can happen.

bmtcril commented 10 months ago

@SoryRawyer can you take a look at this one? Beta server is throwing some:

Code: 72. DB::ParsingException: Cannot read floating point value: Cannot parse Float32 from String: while executing 'FUNCTION CAST(--grades.scaled_score :: 0, 'Float' :: 4) -> CAST(--grades.scaled_score, 'Float') Float32 : 3'. (CANNOT_PARSE

This change seems to fix it.

bmtcril commented 10 months ago

@SoryRawyer that's a way better solution, actually. Can you put that in #34 and we'll get it over the line there?