openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 5 forks source link

fix: write MVs to xapi schema again #39

Closed SoryRawyer closed 9 months ago

SoryRawyer commented 9 months ago

This change overrides the destination database for the materialized views that were once written to the xapi schema so that they can be written to the correct database again. Note: while database is the preferred term when it comes to dbt and ClickHouse, dbt does not seem to recognize database as a valid configuration parameter for model destinations, hence the use of the schema keyword argument in the config block.

This change also requires profiles.yml to pass prod as the target instead of dev. I have updated sample_profiles.yml to match the expected configuration. This also means that the profile in tutor-contrib-aspects will need to be updated as well.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

openedx-webhooks commented 9 months ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bmtcril commented 9 months ago

Released as v3.1.2