openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 5 forks source link

feat: add models for navigation events (FC-0033) #40

Closed SoryRawyer closed 9 months ago

SoryRawyer commented 9 months ago

This PR adds a materialized view for navigation events and an accompanying view that enriches the MV with course and block metadata.

openedx-webhooks commented 9 months ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bmtcril commented 9 months ago

I approved, but can you add docs for these as well, please?

SoryRawyer commented 9 months ago

Ah yes, sorry for the oversight. Also, since there could be either sequential or vertical blocks in these models, does it make sense to leave the fields block_id and block_name as-is? I wasn't sure what a more descriptive name would be.

bmtcril commented 9 months ago

Pretty sure this is good since I think we primarily use block_name_with_location, but let me know if I'm missing something

SoryRawyer commented 9 months ago

I can't think of anything. Thanks!

openedx-webhooks commented 9 months ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

bmtcril commented 9 months ago

Released as v3.2.0