openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 5 forks source link

feat: add support for CCX courses #44

Closed Ian2012 closed 8 months ago

Ian2012 commented 8 months ago

Description

This PR allows us to get the course organization for CCX courses and fixes the get_problem_id regex to include '@' which is part of the URL for CCX courses.

After querying: select * from reporting.fact_problem_responses format Vertical it matches both course formats:

Row 3:
──────
emission_time:              2024-02-19 15:29:41
org:                        edunext
course_key:                 course-v1:edunext+demo+demo
course_name:                Demo
course_run:                 demo
problem_id:                 block-v1:edunext+demo+demo+type@problem+block@3c1646f7133a4c5fb4557d649e22c251
problem_name:               Checkboxes
problem_name_with_location: 2:2:0 - Checkboxes
actor_id:                   9bd74238-97cf-4bff-ab96-d98a6006cba5
responses:                  ["a correct answer", "a correct answer"]
success:                    true
attempts:                   1

Row 4:
──────
emission_time:              2024-02-16 22:15:14
org:                        edunext
course_key:                 ccx-v1:edunext+demo+demo+ccx@1
course_name:                demo CXX
course_run:                 ccx@1
problem_id:                 ccx-block-v1:edunext+demo+demo+ccx@1+type@problem+block@3c1646f7133a4c5fb4557d649e22c251
problem_name:               Checkboxes
problem_name_with_location: 2:2:0 - Checkboxes
actor_id:                   9bd74238-97cf-4bff-ab96-d98a6006cba5
responses:                  ["a correct answer", "an incorrect answer", "a correct answer"]
success:                    false
attempts:                   6

Depends on: https://github.com/openedx/tutor-contrib-aspects/pull/607

openedx-webhooks commented 8 months ago

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Ian2012 commented 8 months ago

Yes, but that's processed at transforming in ERB which should be fixed by this one: https://github.com/openedx/event-routing-backends/pull/392

openedx-webhooks commented 8 months ago

@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.