openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 4 forks source link

feat: order course blocks dictionary #50

Closed Ian2012 closed 6 months ago

Ian2012 commented 6 months ago

Description

This PR migrations the most_recent_course_blocks_mv from Alembic to DBT.

openedx-webhooks commented 6 months ago

Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Ian2012 commented 6 months ago

@SoryRawyer I was trying to get the course structure sorted however, the order by is what defines how to replace in the ReplacingMergeTree engine. Do you have any ideas on how to solve it?

Should I create another model with only the data sorted and make the dictionaries query from it?

bmtcril commented 6 months ago

Ah right, when I looked through this before I didn't see this line, but until we can move the dictionaries this needs to stay in alembic: https://github.com/openedx/tutor-contrib-aspects/blob/d2d9b88c5d9f9f6f9bc38fc14505735e83b7d8b4/tutoraspects/templates/aspects/apps/aspects/migrations/alembic/versions/0023_extend_display_names.py#L137

Ian2012 commented 6 months ago

Closing it for now

openedx-webhooks commented 6 months ago

@Ian2012 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.