Closed Ian2012 closed 4 months ago
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Is this ready for final review now?
@bmtcril Although the dictionaries are created and ran successfully on DBT, query them causes issues with the connection as it uses tries to connect to clickhouse:8123
from the ClickHouse pod which cannot be done. This PR tries to fix that: https://github.com/ClickHouse/dbt-clickhouse/pull/267.
However, if you have any comments regarding the current implementation (besides the above issue) let me know
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR migrates all dictionary definitions and related tables and MVs to DBT.