openedx / aspects-dbt

The dbt project for Open edX Aspects!
Apache License 2.0
2 stars 4 forks source link

feat: add section names to problem dataset (FC-0051) #66

Closed SoryRawyer closed 4 months ago

SoryRawyer commented 4 months ago

This change introduces a new model, fact_problem_responses_extended, which contains section and subsection names alongside problem results. This also includes interaction_type, which specifies the type of answer the problem accepts (e.g. multiple choice)

openedx-webhooks commented 4 months ago

Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

bmtcril commented 4 months ago

@SoryRawyer this should be good, but if you rebase you should have your checks fixed then I can thumb it

bmtcril commented 4 months ago

Well at least it's a legit fail now, docs coverage:

xapi.fact_problem_responses                           14/15     93.3%
xapi.int_problem_results                              13/15     86.7%

 │ │                   │   │   ColumnRef(                                     │ │
│ │                   │   │   │   table_name='xapi.int_problem_results',     │ │
│ │                   │   │   │   column_name='interaction_type'             │ │
│ │                   │   │   ),                                             │ │
│ │                   │   │   ColumnRef(                                     │ │
│ │                   │   │   │   table_name='xapi.int_problem_results',     │ │
│ │                   │   │   │   column_name='graded'                       │ │
│ │                   │   │   ),                                             │ │
│ │                   │   │   ColumnRef(                                     │ │
│ │                   │   │   │   table_name='xapi.fact_problem_responses',  │ │
│ │                   │   │   │   column_name='interaction_type'             │ │
│ │                   │   │   )          
openedx-webhooks commented 4 months ago

@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.