Closed SoryRawyer closed 4 months ago
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
@SoryRawyer this should be good, but if you rebase you should have your checks fixed then I can thumb it
Well at least it's a legit fail now, docs coverage:
xapi.fact_problem_responses 14/15 93.3%
xapi.int_problem_results 13/15 86.7%
│ │ │ │ ColumnRef( │ │
│ │ │ │ │ table_name='xapi.int_problem_results', │ │
│ │ │ │ │ column_name='interaction_type' │ │
│ │ │ │ ), │ │
│ │ │ │ ColumnRef( │ │
│ │ │ │ │ table_name='xapi.int_problem_results', │ │
│ │ │ │ │ column_name='graded' │ │
│ │ │ │ ), │ │
│ │ │ │ ColumnRef( │ │
│ │ │ │ │ table_name='xapi.fact_problem_responses', │ │
│ │ │ │ │ column_name='interaction_type' │ │
│ │ │ │ )
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
This change introduces a new model,
fact_problem_responses_extended
, which contains section and subsection names alongside problem results. This also includesinteraction_type
, which specifies the type of answer the problem accepts (e.g. multiple choice)