Closed Ian2012 closed 4 months ago
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Good point, actor ids should be strings. They can be email addresses or hashes, not always uuids.
This would require a migration is Aspects as the external_id
table uses UUIDs. I will update the queries assuming a migration will be added on a following PR that changes the UUID from UUIDs to string @bmtcril
Hmm there are some complications I need to think about now that we're here. In the case where ERB uses email / hashed email I'm not sure there will actually be rows in external_id for them. We may need to assume user_profile has email and figure out how to handle the hashed version.
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR joins the user PII data with all user-facing reports.