Closed SoryRawyer closed 4 months ago
Thanks for the pull request, @SoryRawyer! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
Since a lot of the engagement charts need to be filtered by section and subsection name I felt it would be helpful to have this model, while at the same time I felt that there were enough models that don't need this information that it would be better to build a separate model instead of adding to the existing one. If this seems too confusing then I'd be happy to consolidate everything into dim_course_blocks
.
@SoryRawyer 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
This change introduces another dimension table,
dim_course_blocks_extended
, which includes the section and subsection names to which each block belongs. This is included as a separate model instead of adding ontodim_course_blocks
so as to avoid any unnecessary joins when a model requires block metadata but does not need the extra information joined intodim_course_blocks
by this new model.