Closed Ian2012 closed 3 months ago
Thanks for the pull request, @Ian2012! Please note that it may take us up to several weeks or months to complete a review and merge your PR.
Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.
Please let us know once your PR is ready for our review and all tests are green.
This seems ok to me, once fact_problem_engagement_v2
is renamed. It seems like the downstream problem engagement reports will all need to be changed to use the new models?
@Ian2012 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.
Description
This PR moves the problem engagement to an MV. A testing model called
fact_problem_engagement_v2
has been created to compare the old model to the new one.In the new model, records with empty
section_subsection_name
are skipped.Author concerns
The data in the new MVs will only be updated once a new problem event is triggered