openedx / axim-engineering

GitHub Issue repository for the Axim engineering team
https://openedx.atlassian.net/wiki/spaces/COMM/pages/3241640370/Axim+Collaborative+Engineering+Team
4 stars 2 forks source link

[GH Request] Codecov token not found in Credentials #1262

Closed MaxFrank13 closed 1 month ago

MaxFrank13 commented 1 month ago

Repository

credentials

Urgency

Medium (< 2 weeks)

Requested Change

When running code coverage in CI for the credentials repo, the workflow throws an error because it is unable to find a Codecov token (source). We'd like to have a token added to the repository (docs).

Reasoning

We want this change to be made so that code coverage can run in CI.

github-actions[bot] commented 1 month ago

Thank you for your report! @openedx/axim-oncall will triage within a business day. Simple requests usually take 2-3 business days to resolve; more complex requests could take longer.

bmtcril commented 1 month ago

@MaxFrank13 there was a duplicate codecov token in the repo, which I've removed per the instructions here: https://openedx.atlassian.net/wiki/spaces/COMM/pages/3438280709/Adding+Codecov . I think tests were running a second time unnecessarily just for Codecov, so I'm removing that and testing things here: https://github.com/openedx/credentials/actions/runs/10962121735/job/30440625824?pr=2588 if you'd like to follow along.

bmtcril commented 1 month ago

Ok this should be set if anyone wants to review and merge it:

info - 2024-09-20 15:46:49,142 -- Found 1 coverage files to report
info - 2024-09-20 15:46:49,142 -- > /home/runner/work/credentials/credentials/coverage.xml
info - 2024-09-20 15:46:49,869 -- Your upload is now processing. When finished, results will be available at: https://app.codecov.io/github/openedx/credentials/commit/9540d2e586c6b1ffe8eeff1dd66923019d3ddf77
info - 2024-09-20 15:46:50,183 -- Process Upload complete
bmtcril commented 1 month ago

Looks like this is doing the right thing, now so I'm going to close it. LMK if you run into any issues.

MaxFrank13 commented 1 month ago

Thanks @bmtcril!