openedx / axim-engineering

GitHub Issue repository for the Axim engineering team
https://openedx.atlassian.net/wiki/spaces/COMM/pages/3241640370/Axim+Collaborative+Engineering+Team
4 stars 1 forks source link

[GH Request] Add viktorrusakov as a member to the `paragon-triage` Github team again #637

Closed adamstankiewicz closed 1 year ago

adamstankiewicz commented 1 year ago

Firm Name

2U

Urgency

High; engineer needs access to manage Paragon project board.

Requested Change

Viktor Rusakov (viktorrusakov) needs "Triage" access to the Paragon Working Group project board again.

This was previously done through this newly created Github team: https://github.com/orgs/openedx/teams/paragon-triage/members

However, Viktor was recently removed from this Github team.

Thanks!

Reasoning

Viktor (incorrectly) recently lost his access to manage the Paragon Working Group project board again through https://github.com/openedx/tcril-engineering/issues/622.

openedx-workflow-automation[bot] commented 1 year ago

Thank you for your report! @openedx/tcril-oncall will take a look as soon as they can.

kdmccormick commented 1 year ago

Taking a look.

kdmccormick commented 1 year ago

Alright, @viktorrusakov should see an invitation back into the org at https://github.com/openedx

@adamstankiewicz , as project admin, you should then be able to give him write access to https://github.com/orgs/openedx/projects/43/settings/access again.

Sorry for the inconvenience! Let me know if there are any issues.

adamstankiewicz commented 1 year ago

@kdmccormick Thanks for the update. I have a couple follow-up questions.

Originally, the Raccoon Gang engineers (including Viktor) lost their access through this issue. The result from that issue was that Adolfo (IIRC) created a new paragon-triage, as the mechanism by which to give the Raccoon Gang engineers (and others) "Triage" access to the repository.

However, giving "Triage" access via the link you provided is a different approach than this previously suggestion to use a new paragon-triage Github team. I also don't have permissions to add users to that Github team (not sure if I'm supposed to).

Given there's now 2 conflicting approaches recommended to grant "Triage" access here, which would you recommend moving forward? The previously mentioned solution of paragon-triage Github team or by managing the project's access settings directly?

I'd like to be giving "Triage" access to the Raccoon Gang engineers in a consistent way. Thanks!

adamstankiewicz commented 1 year ago

Ha, right as I commented that, Viktor informed me has actually got access back to the paragon-triage Github team. It wasn't entirely clear this was going to be the case in the given solution.

@kdmccormick You can pretty much disregard the above message :) Though, I guess I do still wonder about whether I should be able to access to add members to the paragon-triage Github team.

kdmccormick commented 1 year ago

Good questions @adamstankiewicz . There are two different classes of GitHub access which, which we should deconflate:

Giving someone triage-or-higher access to a repository (like paragon) gives them the ability to edit that repository's issues and associated issue-level metadata, like labels, assignees, and milestones. In particular, the paragon-triage team grants triage access to the paragon repository. I added Viktor the that team when I added him back to the org, which I should've been clearer about--my bad!

Giving someone write access to a project (like Paragon Working Group) gives them the ability to manage project-level metadata, like status, boards, and any custom columns you create. I asked you to add Viktor to the PWG project because I thought you'd want to, but it's totally up to you as admin of that project. Unlike repository access, you don't need to go through us for that.

Though, I guess I do still wonder about whether I should be able to access to add members to the paragon-triage Github team.

Yeahhhh, unfortunately, we are currently wary of granting others the ability to add folks to teams, since it circumvents our vetting all openedx org access changes. I agree, though, that something like triage access is pretty harmless. I'll raise it at our next team retro and maybe we can get this part of the process loosened up.

adamstankiewicz commented 1 year ago

Awesome, thank you for the helpful clarifications, Kyle! :)

Yeahhhh, unfortunately, we are currently wary of granting others the ability to add folks to teams, since it circumvents our vetting all openedx org access changes. I'll raise it at our next team retro and maybe we can get this part of the process loosened up.

Totally understandable. Appreciate it in advance! No worries if not; it's pretty straightforward to go through the tCRIL Github Access issue filing process to get the "Triage" access granted.