openedx / course-discovery

Service providing access to consolidated course and program metadata

https://edx-discovery.readthedocs.io/en/latest/

GNU Affero General Public License v3.0

57 stars 171 forks source link

build: add python311 and python312 CI support #4320

Closed ichintanjoshi closed 5 months ago

ichintanjoshi commented 5 months ago

Description

This PR contains changes for upgrading python 3.8 to python 3.11 & 3.12

Changes include :-

Dependencies and version upgrades

Done as a part of following :-

openedx-webhooks commented 5 months ago

Thanks for the pull request, @ichintanjoshi! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

supporting documentation
Open edX discussion forum threads
timeline information ("this must be merged by XX date", and why that is)
partner information ("this is a course on edx.org")
any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

mphilbrick211 commented 5 months ago

Hi @openedx/course-discovery-maintainers! Would someone be able to review this for us? Thanks!

openedx-webhooks commented 5 months ago

@ichintanjoshi 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

iamsobanjaved commented 5 months ago

This PR didn't run unit tests on python 3.11 and 3.12 versions because these versions weren't available on the docker image and the test suites just skipped unit tests. For the services that run CI on docker, we need to modify Dockerfile as well.

py311-django42: skipped because could not find python interpreter with spec(s): py311

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059094#step:4:1646

py312-django42: skipped because could not find python interpreter with spec(s): py312

https://github.com/openedx/course-discovery/actions/runs/8684080396/job/23811059586#step:4:1646

feanil commented 4 months ago

@iamsobanjaved or @ichintanjoshi is one of you working on fixing this?

iamsobanjaved commented 4 months ago

Yup @feanil, almost ready, just need to clean commits, will do shortly.

Fix: https://github.com/openedx/course-discovery/pull/4328

ichintanjoshi commented 4 months ago

@feanil I am coming back from vacation on Monday and will take a look into it.

iamsobanjaved commented 4 months ago

4328 is ready for review, it updates the Dockerfile to add support for Python 3.11 and 3.12

cc @feanil @ichintanjoshi