feat!: Python 3.12 Upgrade

openedx / course-discovery

Service providing access to consolidated course and program metadata

https://edx-discovery.readthedocs.io/en/latest/

GNU Affero General Public License v3.0

57 stars 173 forks source link

feat!: Python 3.12 Upgrade #4405

Closed UsamaSadiq closed 2 months ago

UsamaSadiq commented 3 months ago

Description

Updated GitHub CI and tox to run checks with Python 3.12 env only
Updated requirements with Python 3.12 env
Updated Dockerfile to build with Python 3.12.
Dropped support for Python<3.12

Testing

[x] Tested the docker build locally using make_build with updated Dockerfile to be successful.
[x] CI checks with Python 3.12 are green.

TODO

Python 3.8 checks marked as required need to be removed and Python 3.12 checks need to be marked as required before merging this PR.

UsamaSadiq commented 3 months ago

I have not tested it locally, looks alright. Please squash the commits.

Commits are squashed but we'll need to remove the required checks from repo settings as mentioned in the TODO section of PR description. I don't have access for that so someone from the team or SRE will have to do this change.

DawoudSheraz commented 3 months ago

I have not tested it locally, looks alright. Please squash the commits.

Commits are squashed but we'll need to remove the required checks from repo settings as mentioned in the TODO section of PR description. I don't have access for that so someone from the team or SRE will have to do this change.

Only Axim can do this as they have taken the admin-ship back for Open edX repositories from maintainers as well.

UsamaSadiq commented 2 months ago

FYI @DawoudSheraz I've created axim-engineering issue to remove the required py38 checks from the repo settings. Would you be able to merge the PR after this or does only axim has merge access as well?

DawoudSheraz commented 2 months ago

FYI @DawoudSheraz I've created axim-engineering issue to remove the required py38 checks from the repo settings. Would you be able to merge the PR after this or does only axim has merge access as well?

I can merge the PR once done.

feanil commented 2 months ago

Hey all, the Axim ticket was done and this is blocking some other work so I'm gonna merge this now.

UsamaSadiq commented 2 months ago

@feanil Thanks for merging this PR. Should I raise another ticket to mark Python 3.12 checks as required?

feanil commented 2 months ago

I just added them. FYI in the future, if you have a PR that has run the new checks you can add them even if master doesn't run those checks yet so you can actually make a ticket to remove the old ones and add the new ones if the PR with the new ones has run recently.