openedx / credentials

Service hosting course and program certificates
GNU Affero General Public License v3.0
22 stars 72 forks source link

feat: add badges feature #2489

Closed kyrylo-kh closed 2 months ago

kyrylo-kh commented 4 months ago

Description: This pull request implements Credly integration feature.

Changes:

Related documentation: See temporarily deployed documentation https://raccoongang.github.io/credentials/badges/index.html

Related PR's:

openedx-webhooks commented 4 months ago

Thanks for the pull request, @kyrylo-kh!

What's next?

Please work through the following steps to get your changes ready for engineering review:

:radio_button: Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

:radio_button: Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

:radio_button: Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

:radio_button: Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @2U-aperture. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

:bulb: As a result it may take up to several weeks or months to complete a review and merge your PR.

kyrylo-kh commented 4 months ago

@wowkalucky @GlugovGrGlib please review this PR

justinhynes commented 3 months ago

Just dropping a line to say I'm starting my review this morning.

andrii-hantkovskyi commented 2 months ago

@justinhynes Hi, just wanted to thank you for your remarks. We have gone through all of them and given appropriate responses where no fixes needed. All relevant problems have been fixed. Kindly look at the code again when time allows you to do so :)

justinhynes commented 2 months ago

Hi @andrii-hantkovskyi. Apologies, I missed your last update until today.

I will block out some time to re-review. Thanks for the heads up :)

openedx-webhooks commented 2 months ago

@kyrylo-kh 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.