Add user ids to New Relic as a custom parameter.

openedx / edx-django-utils

edX utilities for Django Application development.

https://edx.readthedocs.io/projects/edx-django-utils/en/latest/

Apache License 2.0

26 stars 20 forks source link

Add user ids to New Relic as a custom parameter. #17

Closed calistenson closed 5 years ago

calistenson commented 5 years ago

Description:

User ids as a custom parameter to New Relic data.

JIRA:

https://openedx.atlassian.net/browse/REVE-69

Merge deadline:

Today - ASAP if possible.

Reviewers:

[ ] @edx/arch-review
[ ] tag reviewer

Merge checklist:

[x] All reviewers approved
[ ] CI build is green
[x] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed
[ ] PR author is listed in AUTHORS

Post merge:

[ ] Create a tag
[ ] Check new version is pushed to PyPi after tag-triggered build is finished.
[ ] Delete working branch (if not needed anymore)

robrap commented 5 years ago

@calistenson @mulby: Is this ok to do from a PII standpoint? The id is designated as PII in the OEP. Maybe have @macdiesel look at this?

douglashall commented 5 years ago

I think you just need to bump the package version here: https://github.com/edx/edx-django-utils/blob/master/edx_django_utils/__init__.py#L7

calistenson commented 5 years ago

@calistenson @mulby: Is this ok to do from a PII standpoint? The id is designated as PII in the OEP. Maybe have @macdiesel look at this?

@robrap I discussed this with Brian Beggs a bit in Arch lunch and since New Relic dumps its data we should be okay from a GDPR standpoint. With PII in particular, since it's the user id and not the user name we thought we would be okay here. We'd like this information for the revenue launch on Monday but if you feel strongly enough we can pause.