search

openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

feat: advertise constraints in setup.py #172

Closed edx-requirements-bot closed 2 years ago

edx-requirements-bot commented 2 years ago
Additional information from script execution [ARCHBOM-1772](https://openedx.atlassian.net/browse/ARCHBOM-1772) Update setup.py to use constraint files when generating requirements files for packaging and distribution. PR generated automatically with Jenkins job cleanup-python-code. Result of running `python setup.py bdist_wheel` before applying fix (in .egg-info/requires.txt)\: psutil django-crum stevedore django-waffle Django newrelic Result of running `python setup.py bdist_wheel` after applying fix (in .egg-info/requires.txt)\: psutil django-crum stevedore django-waffle Django newrelic

Python code cleanup by the cleanup-python-code Jenkins job.

This pull request was generated by the cleanup-python-code Jenkins job, which ran ``` curl -sS "https://raw.githubusercontent.com/edx/edx-cookiecutters/master/scripts/update_setup_py.sh" > update_setup_py.sh bash update_setup_py.sh ```

The following packages were installed: semgrep,isort

robrap commented 2 years ago

@rgraber: I've got some questions/suggestions about the update tool:

  1. What is meant by the following? I don't see any changes in the PR around this.

    The following packages were installed: semgrep,isort

  2. If the before/after results is the same (i.e. a no-op), could we state that instead so we don't need to manually compare and be concerned if we didn't see something?
rgraber commented 2 years ago

@rgraber: I've got some questions/suggestions about the update tool:

1. What is meant by the following? I don't see any changes in the PR around this.

The following packages were installed: semgrep,isort

1. If the before/after results is the same (i.e. a no-op), could we state that instead so we don't need to manually compare and be concerned if we didn't see something?

Missed this comment before I ran the script large-scale, so didn't end up updating the script. The line about which packages were installed comes from the jenkins job.