openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

fix: fix syntax error in code snippet #196

Closed ghassanmas closed 2 years ago

ghassanmas commented 2 years ago

Description:

Just fixing a syntax/typo in Readme

JIRA:

XXX-XXXX

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions: Just replicate this:

Then, open a shell using ./manage.py lms shell and run::

>> from django.apps import apps
>> [app.verbose_name for app  in apps.get_app_configs()]

Reviewers:

  • [ ] tag reviewer

Merge checklist:

Post merge:

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

openedx-webhooks commented 2 years ago

Thanks for the pull request, @ghassanmas! I've created OSPR-6498 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

ghassanmas commented 2 years ago

This ready for review

openedx-webhooks commented 2 years ago

@ghassanmas 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

natabene commented 2 years ago

@ghassanmas @robrap Thank you both.