openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

run make upgrade to update jinja2 #24

Closed DawoudSheraz closed 5 years ago

DawoudSheraz commented 5 years ago

Description:

This PR updates the jinja2 version. Please see PROD-343 for more information.

JIRA:

PROD-343

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

Merge checklist:

Post merge:

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

DawoudSheraz commented 5 years ago

@robrap I created this test PR on the edx-platform against this branch. https://github.com/edx/edx-platform/pull/20726

DawoudSheraz commented 5 years ago

@robrap Sorry to mention again, but I have updated this PR. There were some missing requirements constraints and a few quality fixes that were required for Travis builds to complete successfully. If you can have another look, and if it looks ok, can you merge it? I don't have merge access.

Thank You