openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

feat: Move safe IP address handling code from edx-platform #242

Closed timmc-edx closed 2 years ago

timmc-edx commented 2 years ago

This will allow using the code in all IDAs.

Part of https://github.com/openedx/edx-django-utils/issues/241. Code will be removed from edx-platform in https://github.com/openedx/edx-platform/pull/31000.


Commits best reviewed separately.


Merge checklist:

timmc-edx commented 2 years ago

I don't like repeating the PR title in the body. I can link in the pending edx-platform PR, though. Do you think there's more that needs to be said beyond that?

timmc-edx commented 2 years ago

I'm going to try to improve coverage and add pragmas where it doesn't seem worth it.

robrap commented 2 years ago

I don't like repeating the PR title in the body. I can link in the pending edx-platform PR, though. Do you think there's more that needs to be said beyond that?

Nope. We just have different preferences. Your PR. Go with yours. 🙂

timmc-edx commented 2 years ago

Rewrote branch into two commits: One that's basically a straight copy, and one that makes new changes.

timmc-edx commented 2 years ago

(rebased onto master)

timmc-edx commented 2 years ago

(adjusted changelog date)