openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

BOM-1013 #28

Closed awais786 closed 4 years ago

awais786 commented 4 years ago

https://openedx.atlassian.net/browse/BOM-1013 Add tox environments for Django 2.0, 2.1, and 2.2 under Python 3.5

Description:

Describe in a couple of sentence what this PR adds

JIRA:

https://openedx.atlassian.net/browse/BOM-1013

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

Merge checklist:

Post merge:

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

awais786 commented 4 years ago

@jmbowman plz review.

awais786 commented 4 years ago

Starting from version 3.1, pytest now automatically catches warnings during test execution and displays them at the end of the session. We are using pytest==4.6.6

awais786 commented 4 years ago

@jmbowman PR is ready for final review.

awais786 commented 4 years ago

@jmbowman I don't have merging rights.

jmbowman commented 4 years ago

Huh, there's an unusual restriction on who can merge to master in this repo. Just merged and tagged.