openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

Plugins test files not seen by coverage reports #305

Closed robrap closed 1 year ago

robrap commented 1 year ago

Plugins test files are not seem by the coverage report, which probably means they aren't running. Either way, we should get this coverage gap fixed.

See https://app.codecov.io/gh/openedx/edx-django-utils

Screenshot 2023-04-28 at 11 12 08 AM

The drop in coverage started on this commit: https://app.codecov.io/gh/openedx/edx-django-utils/commit/3639ab70e18012534f730b4cff0469a2a1e43c77

robrap commented 1 year ago

@UsamaSadiq: Note that if this turns out to be an issue that could affect multiple repos, we should inform and/or fix. Thank you.

nedbat commented 1 year ago

The drop in coverage started on this commit: https://app.codecov.io/gh/openedx/edx-django-utils/commit/3639ab70e18012534f730b4cff0469a2a1e43c77

That commit moved coverage.py from 6.x to 7.x, which changed how wildcards are interpreted.

The wildcards in .coveragerc probably need to be updated, as described here: https://coverage.readthedocs.io/en/7.2.5/migrating.html

UsamaSadiq commented 1 year ago

Created PR https://github.com/openedx/edx-django-utils/pull/308 with the suggested fix that resolved the coverage drop issue.