openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

Sujatadas #339

Closed sroycho4 closed 1 year ago

sroycho4 commented 1 year ago

Description:

Describe in a couple of sentence what this PR adds

JIRA:

XXX-XXXX

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

Merge checklist:

Post merge:

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

openedx-webhooks commented 1 year ago

Thanks for the pull request, @sroycho4! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

:warning: We can't start reviewing your pull request until you've submitted a signed contributor agreement or indicated your institutional affiliation. Please see the CONTRIBUTING file for more information. If you've signed an agreement in the past, you may need to re-sign. See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed. After this time, you can re-run the CLA check by editing the PR title. If the problem persists, you can tag the @openedx/cla-problems team in a comment on your PR for further assistance.

robrap commented 1 year ago

Hello @sroycho4. I appreciate your willingness to contribute, but the change actually causes a problem in the sentence, so we won't be accepting this change. You would only need to complete the step for signing an agreement if you plan to contribute again. Thanks again and good luck.

openedx-webhooks commented 1 year ago

@sroycho4 Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.