ENT-2724 | added get_cache_key utility. - Githubissues

openedx / edx-django-utils

edX utilities for Django Application development.

https://edx.readthedocs.io/projects/edx-django-utils/en/latest/

Apache License 2.0

26 stars 20 forks source link

ENT-2724 | added get_cache_key utility. #35

Closed HammadAhmadWaqas closed 4 years ago

HammadAhmadWaqas commented 4 years ago

Description:

added get_cache_key() utilty.

JIRA:

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions:

Open page A
Do thing B
Expect C to happen
If D happened instead - check failed.

Reviewers:

[ ] @edx/arch-review (Required)
[ ] tag reviewer

Merge checklist:

[ ] All reviewers approved
[ ] CI build is green
[ ] Version bumped
[ ] Changelog record added
[ ] Documentation updated (not only docstrings)
[ ] Commits are squashed
[ ] PR author is listed in AUTHORS

Post merge:

[ ] Create a tag
[ ] Check new version is pushed to PyPi after tag-triggered build is finished.
[ ] Delete working branch (if not needed anymore)

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

HammadAhmadWaqas commented 4 years ago

@robrap Thank you for detailed review. I have made suggested changes. can you please review it again.