openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

Removing ceninusepy3 and update requirements. #39

Closed awais786 closed 4 years ago

awais786 commented 4 years ago

https://openedx.atlassian.net/browse/BOM-1662

Removing ceninusepy3 update requirements.

Description:

Describe in a couple of sentence what this PR adds

JIRA:

XXX-XXXX

Dependencies:

List dependencies on other outstanding PRs, issues, etc.

Merge deadline:

List merge deadline (if any)

Installation instructions:

List any non-trivial installation instructions.

Testing instructions:

  1. Open page A
  2. Do thing B
  3. Expect C to happen
  4. If D happened instead - check failed.

Reviewers:

Merge checklist:

Post merge:

Author concerns:

List any concerns about this PR - inelegant solutions, hacks, quick-and-dirty implementations, concerns about migrations, etc.

robrap commented 4 years ago

Also, can you please get continuous-integration/travis-ci unstuck? Thank you.

awais786 commented 4 years ago

Please confirm that your team did your own review of the upgrade changes using https://openedx.atlassian.net/wiki/spaces/TE/pages/1001521320/Python+Package+Changelogs

I will merge as soon as you confirm it is ready. Thanks.

@robrap I have updated the changelog. If you are asking about team is doing own reviews answer is Yes.

robrap commented 4 years ago

@awais786: I know you do your own reviews generally. The Changelog Confluence page I sent is used to review external changelogs for dependencies that are being updated, and I was just checking that you had done that. From the version numbers, it doesn't look like there is anything particularly noteworthy though.

Do you know what is behind the continuous-integration/travis-ci issue? Is that a larger issue we are seeing elsewhere?

Good luck.

awais786 commented 4 years ago

@awais786: I know you do your own reviews generally. The Changelog Confluence page I sent is used to review external changelogs for dependencies that are being updated, and I was just checking that you had done that. From the version numbers, it doesn't look like there is anything particularly noteworthy though.

Do you know what is behind the continuous-integration/travis-ci issue? Is that a larger issue we are seeing elsewhere?

Good luck.

For continuous-integration/travis-ci issue its happening in this repo only right now. We have merged prs in several other repos and travis working fine there.

robrap commented 4 years ago

Thanks @awais786!