Closed timmc-edx closed 3 months ago
Requesting clarification from Datadog about whether set_metric is even what we would want to call: https://help.datadoghq.com/hc/en-us/requests/1773961 (2U private link)
Got an answer:
set_metric
in ddtrace is for span tags (with numeric values), not actual metrics.We may hold off on this and have Purchase try out dogstatsd in a private plugin if it turns out they need it, and then consider building out an abstraction layer in edx-django-utils based on what we learn from that.
Thanks. I would guess that SRE has experience deploying dogstatsd, which could be confirmed. I think Purchase should be pointed to SRE for support around the setup.
https://2u-internal.atlassian.net/browse/SONIC-409 is being used to PoC this functionality, rather than jumping to adding anything to the edx-django-utils API.
I'm going to close this ticket as unplanned, and we'll revisit when and if it is needed in the future.
Acceptance criteria:
add_metric
(or similar) monitoring function, complementing span tag/custom attribute collectionImplementation notes:
datadog
Python package and install the DogStatsD agent.ddtrace.Span.set_metric
in ddtrace! That's not actually metrics.record_custom_metric
and pull-based viaregister_data_source
-- and each value can be a number or a dictionary of statistical aggregations (count/total/min/max) that don't match the other systems' metric breakdowns. It also has a naming scheme that may conflict with other implementations. It might be that NR users should just use the OTel integration. See comparison of support.