openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

Moving logging filters from edx-platform #65

Closed moconnell1453 closed 4 years ago

moconnell1453 commented 4 years ago

Description:

Moving logging filters for user and remote IP to this repo, so they can be re-used by newly created IDAs through the cookie-cutter template.

JIRA:

https://openedx.atlassian.net/browse/SEG-34

Dependencies:

None

Merge deadline:

None

Installation instructions:

None

Testing instructions:

  1. Update edx-django-utils to latest version
  2. Confirm that the UserFilter and RemoteIpFilter can be imported from edx_django_utils.logging.filters

Reviewers:

Merge checklist:

Post merge:

Author concerns:

None

regisb commented 4 years ago

@moconnell1453 Do you think you could document this utility in the project docs/?

robrap commented 4 years ago

I plan to do some refactoring in this repo, following the advice in this ADR: https://github.com/edx/edx-toggles/blob/master/docs/decisions/0004-toggle-api.rst. Although the ADR is in a different repo (for now), it was written based on experience from the other apps in this repo. If you follow this ADR, using an internal directory and a separate public API, it would be appreciated. 🙂

moconnell1453 commented 4 years ago

jenkins run all