openedx / edx-django-utils

edX utilities for Django Application development.
https://edx.readthedocs.io/projects/edx-django-utils/en/latest/
Apache License 2.0
26 stars 20 forks source link

ARCHBOM-1584: refactor monitoring app #70

Closed robrap closed 3 years ago

robrap commented 4 years ago

Description:

Note: Some additional details in the CHANGELOG.rst change in the PR.

JIRA:

ARCHBOM-1584

Testing instructions:

Merge checklist:

Post merge:

robrap commented 4 years ago

Thanks for your thoughts, @idegtiarov. I'll look into whatever is reasonably quick.

  1. Black is hopefully coming in the future to help with code consistency.
  2. I was trying to squeeze in a step in the right direction, but there will always be more that can be done, especially for existing code that is being moved around.
idegtiarov commented 4 years ago

@robrap Thanks for the answers and clarifications.

robrap commented 3 years ago

@feanil: FYI: I plan on merging, but I wanted to let you know I added these tests for an existing middleware to increase coverage: https://github.com/edx/edx-django-utils/blob/241bb42ae5f511c25ab095018d05966cd509c63d/edx_django_utils/monitoring/tests/test_middleware.py