search

openedx / edx-documentation

http://docs.edx.org
Other
161 stars 333 forks source link

Move XBlock Tutorial to XBlock repo #2206

Closed sarina closed 7 months ago

sarina commented 8 months ago

@feanil - depends on https://github.com/openedx/XBlock/pull/686

sarina commented 7 months ago

@feanil do you know why the two checks aren't running (docs/readthedocs.org:edx-developer-guide and open-edx-release-notes)? We moved both of those guides anyway so shouldn't we remove these checks?

feanil commented 7 months ago

Looks like those two checks are required in GitHub but maybe no longer setup. I agree that they should just be removed from the set of required checks.

sarina commented 7 months ago

Hmm. I tried removing them from run_tests.sh but that didn't make the build icon go away (still says it's "expected"). I'm not sure how to disable the check otherwise.

feanil commented 7 months ago

Oh yea the update is in the github settings but it looks like this is actually related to a new change on the RTD side, I'm fixing that now.

sarina commented 7 months ago

Should I back this commit out? https://github.com/openedx/edx-documentation/pull/2206/commits/140ab26f2e987a35610167c17b92a0942f3d257e

feanil commented 7 months ago

Yea, you should remove that commit, I think it's still good to test the redirect builds are working as expected and should be pretty fast.