search

openedx / edx-lint

Custom tooling for pylint and other repo management tools
Apache License 2.0
51 stars 26 forks source link

Remove pylint_django plugin #21

Open clintonb opened 8 years ago

clintonb commented 8 years ago

The pylint_django plugin is required (https://github.com/edx/edx-lint/blob/96f4c58137f73bd4798400c4107dbf1a422dc34f/edx_lint/files/pylintrc#L22), but is not included as a dependency of this package. Unless this is intended only for Django projects, pylint_django should not be a default plugin.

nedbat commented 8 years ago

pylint_django is listed in setup.py as a dependency.

I can see why we shouldn't include this plugin in all repos, but I'd like to find a way to uniformly apply it to our Django projects.

clintonb commented 8 years ago

It seems I misread setup.py. Closing as there is no immediate need to remove pylint_django.

nedbat commented 8 years ago

No need to remove the plugin, but we should disable the message it prints if there's no Django installed: disable=django-not-available