search

openedx / edx-lint

Custom tooling for pylint and other repo management tools
Apache License 2.0
50 stars 26 forks source link

Unpin importlib-metadata #407

Closed timmc-edx closed 1 month ago

timmc-edx commented 6 months ago

In https://github.com/openedx/edx-lint/pull/406 we pinned importlib-metadata to before 7.x. Once https://github.com/open-telemetry/opentelemetry-python/issues/3570 resolves we should unpin this.

This pin is in place because we want to use opentelemetry from edx-django-utils. Normally this could be added as a constraint in edx-django-utils, where we're adding the opentelemetry dependency. However, when we compile pip-tools.txt in dependent IDA repos, that layer ends up using version 7.x, and then there's no undoing that when compiling base.txt. So we need to pin it globally, for now.

zameel7 commented 1 month ago

@timmc-edx, can we unpin this now? Seems like https://github.com/open-telemetry/opentelemetry-python/issues/3570 is resolved.

timmc-edx commented 1 month ago

Ah yes, thank you! I had forgotten to subscribe to that issue.

zameel7 commented 1 month ago

Ah yes, thank you! I had forgotten to subscribe to that issue.

Any time! Hope we can close this issue now. @timmc-edx

timmc-edx commented 1 month ago

Oh yeah, we can! Thanks again.